Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jaclib #1477

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

jaclib #1477

wants to merge 11 commits into from
+1,178 −819

Conversation

ThakeeNathees
Copy link
Collaborator

Description

@ThakeeNathees ThakeeNathees force-pushed the thakee-py-codegen-new branch 5 times, most recently from 33d79c3 to 63f3fde Compare December 6, 2024 17:31
@ThakeeNathees ThakeeNathees force-pushed the thakee-py-codegen-new branch 4 times, most recently from 5254135 to b627a17 Compare December 12, 2024 12:16
This was referenced Dec 17, 2024
Closed
Closed
@ThakeeNathees ThakeeNathees force-pushed the thakee-py-codegen-new branch 2 times, most recently from 7804130 to b2529bf Compare December 23, 2024 20:31
@ThakeeNathees ThakeeNathees force-pushed the thakee-py-codegen-new branch 2 times, most recently from 959ae75 to 3fc2fff Compare December 27, 2024 12:16
@ThakeeNathees ThakeeNathees force-pushed the thakee-py-codegen-new branch from 3fc2fff to b9cf01d Compare January 6, 2025 15:04
@ThakeeNathees ThakeeNathees changed the title [WIP] jac2py codegen refactored [WIP] jaclib Jan 10, 2025
@ThakeeNathees ThakeeNathees force-pushed the thakee-py-codegen-new branch 12 times, most recently from 2dacadc to 8a21948 Compare January 14, 2025 14:56
@ThakeeNathees ThakeeNathees changed the title [WIP] jaclib jaclib Jan 14, 2025
@ThakeeNathees ThakeeNathees force-pushed the thakee-py-codegen-new branch 4 times, most recently from 86e0f0a to bdf9dc5 Compare January 24, 2025 12:27
ThakeeNathees and others added 6 commits January 27, 2025 00:04
@ThakeeNathees
jac2py codegen refactored
e9be21a
@ThakeeNathees
tests were fixed
8044766
@ThakeeNathees
review changes were added
363a9ad
@ThakeeNathees
small updated after review
b0cda22
@marsninja @ThakeeNathees
tweak: architype inheritance check
c6d1a52
@ThakeeNathees
Update after jason review:
4364891 
- List changed to JacList
- All architype share the same meta class, support for cross inheritance
- Types annotation were added to root node so type check pass tests
  are passing.
@amadolid
Copy link
Collaborator

amadolid commented Jan 27, 2025 •
edited
Loading

Hello @ThakeeNathees ,

Would like to know if this also consider the previous PR for decluttering architypes.
The idea is, as much as possible architypes should not holds any default functions/attributes (private ones might be debatable). The reason for it is, architypes are like "frontend" class representation on jac lang. Dev can add any implementation there. Adding hidden default functions/attributes might got overridden by devs as we don't tagged it as reserved keywords.

In my perspective, architypes should be just object holders (models), JacFeature is the processor (services) and API or CLI is the controller

You may check this PR #1316

cc: @ypkang , @marsninja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThakeeNathees @amadolid @marsninja @Thamirawaran